netdev - Re: v3.12-stable-queue build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150427.122528.2203423133753350979.davem@davemloft.net>
Date:	Mon, 27 Apr 2015 12:25:28 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ebiederm@...ssion.com
Cc:	jslaby@...e.cz, netdev@...r.kernel.org, linux@...ck-us.net,
	stable@...r.kernel.org
Subject: Re: v3.12-stable-queue build errors

From: ebiederm@...ssion.com (Eric W. Biederman)
Date: Mon, 27 Apr 2015 10:35:51 -0500

> Jiri Slaby <jslaby@...e.cz> writes:
> 
>> On 04/25/2015, 04:16 PM, Guenter Roeck wrote:
>>> Several powerpc build fail with:
>>> 
>>> drivers/net/ethernet/freescale/gianfar.c: In function 'gfar_start_xmit':
>>> drivers/net/ethernet/freescale/gianfar.c:2146:3: error: implicit declaration of
>>> function 'dev_consume_skb_any' [-Werror=implicit-function-declaration]
>>>    dev_consume_skb_any(skb);
>>> 
>>> dev_consume_skb_any() does not exist in 3.12.
>>> 
>>> Introduced by 'gianfar: Carefully free skbs in functions called by netpoll'.
>>
>> Eric, David,
>>
>> what action should I take here?
>>
>> 1) take also:
>> commit e6247027e5173c00efb2084d688d06ff835bc3b0
>> Author: Eric Dumazet <edumazet@...gle.com>
>> Date:   Thu Dec 5 04:45:08 2013 -0800
>>
>>     net: introduce dev_consume_skb_any()
>>
>>
>> 2) drop 'gianfar: Carefully free skbs in functions called by netpoll'
>> from stable-3.12
> 
> This is probably the most reasonable.   KISS.

Yeah just drop the patch.

I didn't even want to submit this series in the first place but
people kept poking me endlessly about it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html