netdev - Re: [PATCH net-next v7] Add support of Cavium Liquidio ethernet adapters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Apr 2015 12:27:31 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	Derek.Chickles@...iumnetworks.com
Cc:	Raghu.Vatsavayi@...iumnetworks.com, netdev@...r.kernel.org,
	Satananda.Burla@...iumnetworks.com,
	Felix.Manlunas@...iumnetworks.com
Subject: Re: [PATCH net-next v7] Add support of Cavium Liquidio ethernet
 adapters

From: "Chickles, Derek" <Derek.Chickles@...iumnetworks.com>
Date: Mon, 27 Apr 2015 16:26:27 +0000

>> 
>> It is extremely disappointing that you've defined your own debug
>> logging macros, which use generic dev_*() printks, instead of using
>> the proper netdev_*() printk logging interfaces to do this.
> 
> We can make this change. I'm not sure why it was missed since we
> have netif_level support. Please note, we will still need to use the
> dev_ macros for those places in the driver where we don't have a
> netdev yet.

Of course.

But there is no reason to go through a special locally defined
macros to do this stuff.  Just invoke dev_* and netdev_* directly.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html