netdev - Re: [PATCH net-next v7] Add support of Cavium Liquidio ethernet adapters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150427.132242.1898729531212160949.davem@davemloft.net>
Date:	Mon, 27 Apr 2015 13:22:42 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	Derek.Chickles@...iumnetworks.com
Cc:	Raghu.Vatsavayi@...iumnetworks.com, netdev@...r.kernel.org,
	Satananda.Burla@...iumnetworks.com,
	Felix.Manlunas@...iumnetworks.com
Subject: Re: [PATCH net-next v7] Add support of Cavium Liquidio ethernet
 adapters

From: "Chickles, Derek" <Derek.Chickles@...iumnetworks.com>
Date: Mon, 27 Apr 2015 17:04:35 +0000

> 
>> >>
>> >> It is extremely disappointing that you've defined your own debug
>> >> logging macros, which use generic dev_*() printks, instead of using
>> >> the proper netdev_*() printk logging interfaces to do this.
>> >
>> > We can make this change. I'm not sure why it was missed since we
>> > have netif_level support. Please note, we will still need to use the
>> > dev_ macros for those places in the driver where we don't have a
>> > netdev yet.
>> 
>> Of course.
>> 
>> But there is no reason to go through a special locally defined
>> macros to do this stuff.  Just invoke dev_* and netdev_* directly.
> 
> I think the main reason we're doing this is because we're passing around
> struct octeon_device (which has a pcI_dev pointer and a netdev pointer)
> through some parts of the code and felt the consistency in the printk
> interface was better than having extra pointer dereferences (like
> &oct->pci_dev->dev) inline in the code.  Do you mind if we keep wrappers
> for those pieces? The other places where netdev is immediately available
> can easily be changed.

I don't think this is reasonable.

You can always get to the octeon_device object from the netdev pointer,
so pass that everywhere.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html