netdev - Re: [PATCH net-next 2/2] tcp: add tcpi_bytes_received to tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1430259686.28069.29.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 28 Apr 2015 15:21:26 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Yuchung Cheng <ycheng@...gle.com>
Cc:	Eric Dumazet <edumazet@...gle.com>,
	"David S. Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Matt Mathis <mattmathis@...gle.com>,
	Eric Salo <salo@...gle.com>, Martin Lau <kafai@...com>,
	Chris Rapier <rapier@....edu>
Subject: Re: [PATCH net-next 2/2] tcp: add tcpi_bytes_received to tcp_info

On Tue, 2015-04-28 at 14:07 -0700, Yuchung Cheng wrote:

> Account for received syn-data when rcv_nxt is updated in tcp_fastopen.c?

Right, I'll send a v2 with the following FO part :

Note that I do not call the helper to keep it static and inline
candidate.

Thanks !

diff --git a/net/ipv4/tcp_fastopen.c b/net/ipv4/tcp_fastopen.c
index e3d87aca6be8..b1b110d07816 100644
--- a/net/ipv4/tcp_fastopen.c
+++ b/net/ipv4/tcp_fastopen.c
@@ -206,6 +206,7 @@ static bool tcp_fastopen_create_child(struct sock *sk,
                        skb_set_owner_r(skb2, child);
                        __skb_queue_tail(&child->sk_receive_queue, skb2);
                        tp->syn_data_acked = 1;
+                       tp->bytes_received = end_seq - (TCP_SKB_CB(skb)->seq + 1);
                } else {
                        end_seq = TCP_SKB_CB(skb)->seq + 1;
                }


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html