netdev - Re: [bisected] ICMP fragmentation needed ignored / PMTU discovery broken since 3.19-rc7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150428034314.GA30299@gondor.apana.org.au>
Date:	Tue, 28 Apr 2015 11:43:15 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	"Gerd v. Egidy" <gerd.von.egidy@...ra2net.com>
Cc:	netdev@...r.kernel.org, lw@...fujitsu.com, davem@...emloft.net
Subject: Re: [bisected] ICMP fragmentation needed ignored / PMTU discovery
 broken since 3.19-rc7

Gerd v. Egidy <gerd.von.egidy@...ra2net.com> wrote:
> 
> my colleagues recently reported that they had spurious problems connecting
> to a specific server via ssh. Investigation showed that the kernel completely 
> ignored the ICMP dest. unreachable / fragmentation needed packets in this case:

This patch might help:

---8<---
Subject: route: Use ipv4_mtu instead of raw rt_pmtu

The commit 3cdaa5be9e81a914e633a6be7b7d2ef75b528562 ("ipv4: Don't
increase PMTU with Datagram Too Big message") broke PMTU in cases
where the rt_pmtu value has expired but is smaller than the new
PMTU value.

This obsolete rt_pmtu then prevents the new PMTU value from being
installed.

Fixes: 3cdaa5be9e81 ("ipv4: Don't increase PMTU with Datagram Too Big message")
Reported-by: Gerd v. Egidy <gerd.von.egidy@...ra2net.com>
Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index a78540f..bff62fc 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -962,10 +962,7 @@ static void __ip_rt_update_pmtu(struct rtable *rt, struct flowi4 *fl4, u32 mtu)
 	if (dst_metric_locked(dst, RTAX_MTU))
 		return;

-	if (dst->dev->mtu < mtu)
-		return;
-
-	if (rt->rt_pmtu && rt->rt_pmtu < mtu)
+	if (ipv4_mtu(dst) < mtu)
 		return;

 	if (mtu < ip_rt_min_pmtu)
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html