| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 28 Apr 2015 12:44:37 -0400 (EDT) From: David Miller <davem@...emloft.net> To: ivecera@...hat.com Cc: Sathya.Perla@...lex.Com, netdev@...r.kernel.org, subbu.seetharaman@...lex.Com, Ajit.Khaparde@...lex.Com Subject: Re: [PATCH net-next v2] be2net: log link status From: Ivan Vecera <ivecera@...hat.com> Date: Tue, 28 Apr 2015 16:32:37 +0200 > On 04/23/2015 08:31 AM, Sathya Perla wrote: >>> -----Original Message----- >>> From: Ivan Vecera [mailto:ivecera@...hat.com] >>> >>> The driver unlike other drivers does not log link state changes. >>> >>> v2: added current link speed to log message >>> >> Ivan, I disagree with the v2 change. I think your original intention >> was just to log a message when the link goes up or down >> asynchronously (i.e., without any user intervention.) >> After alerting the user, if the user wants to know other link >> properties like speed, duplex etc then the ethtool cmd needs >> to be used; there is no need to log a message with those details. >> >> -- >> To unsubscribe from this list: send the line "unsubscribe netdev" in >> the body of a message to majordomo@...r.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > Dave, could we apply the v1 WRT Sathya's comment? Patches should be resubmitted freshly when people want me to do something like this. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists