netdev - Re: [PATCH] ss: Fix wrong filter behaviour

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <55414B85.1070204@ionic.de>
Date:	Wed, 29 Apr 2015 23:22:13 +0200
From:	Mihai Moldovan <ionic@...ic.de>
To:	Vadim Kochan <vadim4j@...il.com>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH] ss: Fix wrong filter behaviour

On 28.04.2015 03:37 PM, Vadim Kochan wrote:
> On Tue, Apr 28, 2015 at 04:16:48PM +0300, Vadim Kochan wrote:
>> From: Vadim Kochan <vadim4j@...il.com>
>>
>> Fixed applying family & socket type filters.
>> It was not possible to select UDP & UNIX sockets together.
>>
>> Now selected families are ORed.
>>
>> The problem was that filters were combined by AND.
>>
>> Signed-off-by: Vadim Kochan <vadim4j@...il.com>
>> Reported-By: Mihai Moldovan <ionic@...ic.de>
>> ---
>>  misc/ss.c | 91 ++++++++++++++++++++++++++++++++++-----------------------------
>>  1 file changed, 49 insertions(+), 42 deletions(-)
>>
>> diff --git a/misc/ss.c b/misc/ss.c
>> index 954a30b..46dbb39 100644
>> [...]
> 
> Would you please respond if you received this patch ?
> I am just checking, in case if it was get into 'Spam' list.
> 
> Regards,

I finally came around to testing this, sorry it took me so long.

Using that patch, the output looks much better. It works for my use case.

What do we do with the "broken" versions, though? Even if that patch hits 4.1.0,
older versions like 4.0.0, 3.19.0 etc. will still be broken?



Mihai


Download attachment "signature.asc" of type "application/pgp-signature" (885 bytes)