netdev - Re: [PATCH 4/6] netfilter: move generic hook infrastructure into net/core/hooks.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150429235932.GC7025@acer.localdomain>
Date:	Thu, 30 Apr 2015 01:59:32 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Pablo Neira Ayuso <pablo@...filter.org>
Cc:	netfilter-devel@...r.kernel.org, davem@...emloft.net,
	netdev@...r.kernel.org, jhs@...atatu.com
Subject: Re: [PATCH 4/6] netfilter: move generic hook infrastructure into
 net/core/hooks.c

On 29.04, Pablo Neira Ayuso wrote:
> This patch moves the very basic hook infrastructure into net/core/hooks.c
> and it also adds a new CONFIG_NETFILTER_HOOKS kconfig switch.
> 
> The idea is to allow CONFIG_NETFILTER_HOOKS selection from qdisc ingress
> without depending on the full Netfilter layer 3 hooks (ie. CONFIG_NETFILTER).
> 
> Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>
> ---
>  MAINTAINERS                      |    1 +
>  include/linux/netfilter.h        |   96 +----------------------
>  include/linux/netfilter_hooks.h  |  117 ++++++++++++++++++++++++++++
>  include/net/netfilter/nf_queue.h |    1 +
>  net/Kconfig                      |    7 ++
>  net/core/Makefile                |    1 +
>  net/core/dev.c                   |    2 +
>  net/core/hooks.c                 |  159 ++++++++++++++++++++++++++++++++++++++
>  net/netfilter/core.c             |  149 +----------------------------------
>  net/netfilter/nf_internals.h     |    2 -

Just a general comment, still reviewing in detail, but it would be preferrable
to have a diff using -M -C to have the rename seen in the diff itself.

Cheers,
Patrick
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html