netdev - Re: [PATCH V2 net-next] net: merge redundancy judgement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20150429.115932.495579567064625984.davem@davemloft.net>
Date:	Wed, 29 Apr 2015 11:59:32 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	martinbj2008@...il.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 net-next] net: merge redundancy judgement

From: Martin Zhang <martinbj2008@...il.com>
Date: Wed, 29 Apr 2015 17:09:24 +0800

> 'if' and 'elseif' do the same operation,
> so merge then into a case.
> 
> Signed-off-by: Martin Zhang <martinbj2008@...il.com>
> ---
>  net/ipv4/route.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> index a78540f..2a50411 100644
> --- a/net/ipv4/route.c
> +++ b/net/ipv4/route.c
> @@ -801,11 +801,8 @@ static struct dst_entry *ipv4_negative_advice(struct dst_entry *dst)
>  	struct dst_entry *ret = dst;
>  
>  	if (rt) {
> -		if (dst->obsolete > 0) {
> -			ip_rt_put(rt);
> -			ret = NULL;
> -		} else if ((rt->rt_flags & RTCF_REDIRECTED) ||
> -			   rt->dst.expires) {
> +		if (dst->obsolete > 0 || (rt->rt_flags & RTCF_REDIRECTED) ||
> +			rt->dst.expires) {

This is not indented properly.

When an if() condition spans multiple lines, the second and subsequent lines
must start precisely at the first column after the openning parenthesis of
the first line.  You must use the appropriate number of TAB and SPACE
characters necessary to do so.

You would do well to simply follow the coding style that existed in the
lines you are editing, because you are only running into trouble because
you are styling things differently from what is happening there already.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html