netdev - Re: iproute2: Make linux/in6.h a stub?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 29 Apr 2015 19:36:58 +0200
From:	Felix Janda <felix.janda@...teo.de>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	netdev@...r.kernel.org
Subject: Re: iproute2: Make linux/in6.h a stub?

Stephen Hemminger wrote:
> On Sat, 25 Apr 2015 22:54:11 +0200
> Felix Janda <felix.janda@...teo.de> wrote:
> 
> > Hello.
> > 
> > Background:
> > Current iproute2 does not build when the libc is musl instead of glibc.
> > This is because of redefinition of in6_addr in netinet/in.h and
> > linux/in6.h. There are workarounds in linux/libc-compat.h to make it
> > somehow work for glibc.
> > 
> > 
> > As I can see linux/in6.h is only indirectly used via the other kernel
> > headers linux/if_bridge.h and linux/xfrm.h. These in turn include
> > linux/in6.h only in order to get a declaration of in6_addr.
> > 
> > Since iproute2 depends on the fact that in6_addr is defined in
> > <netinet/in.h> it should be safe to replace the content of linux/in6.h
> > by
> > 
> > #include <netinet/in.h>
> > 
> > This completely removes the possibility for redefinition of in6_addr
> > for any libc. Since linux/in6.h is anyway a patched kernel header, such
> > a change should also not increase the work needed to sync with newer
> > kernel headers.
> > 
> > Would it be possible to implement such a change?
> > 
> > Felix
> 
> I appreciate the effort to make iproute2 in other environments.
> The header files in linux for iproute2 are automatically generated
> from the upstream kernel headers. A lot of effort has been done
> to align kernel, iproute2 and glibc. Therefore doing something
> special just to work around incompatibles with other
> environments is not going to be accepted.
> 
> Any other libc has to be compatible with glibc in this area
> rather than introducing more complexity in what is already fragile.

Thanks for your consideration. I see that you want to stay as close to
upstream kernel headers as possible and cannot argue against that. So
in order of not having to patch iproute2 it will be necessary to get
fixes to the upstream kernel headers.

Felix
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html