netdev - Re: [PATCH 2/3] r8169: Use dev_kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150501.113659.1615816780747363615.davem@davemloft.net>
Date:	Fri, 01 May 2015 11:36:59 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	LinoSanfilippo@....de
Cc:	romieu@...zoreil.com, alexander.h.duyck@...hat.com,
	netdev@...r.kernel.org, nic_swsd@...ltek.com,
	Dept-HSGLinuxNICDev@...gic.com, sony.chacko@...gic.com,
	intel-wired-lan@...ts.osuosl.org, jeffrey.t.kirsher@...el.com,
	ebiederm@...ssion.com
Subject: Re: [PATCH 2/3] r8169: Use dev_kfree_skb in Tx cleanup path

From: Lino Sanfilippo <LinoSanfilippo@....de>
Date: Fri, 01 May 2015 14:15:42 +0200

> On 01.05.2015 14:06, Lino Sanfilippo wrote:
> 
>> which did just the opposite: replace dev_kfree() with dev_kfree_any()
>> for that reason. See
>> 
> 
> Um, this should of course be dev_kfree_skb() and dev_kfree_skb_any().

Indeed.

Alex, you can't make this change.  netconsole transmits can occur
from any context whatsoever.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html