| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20150501.211225.641281069847184355.davem@davemloft.net> Date: Fri, 01 May 2015 21:12:25 -0400 (EDT) From: David Miller <davem@...emloft.net> To: maheshb@...gle.com Cc: netdev@...r.kernel.org, edumazet@...gle.com, dcbw@...hat.com Subject: Re: [PATCH next v2 2/3] ipvlan: Process fragmented multicast frames correctly From: Mahesh Bandewar <maheshb@...gle.com> Date: Wed, 29 Apr 2015 11:19:18 -0700 > Multicast processing in IPvlan was faulty as is. Eric Dumazet > pointed out that fragmented packets won't be processed correctly > unless defrag step is introduced. > > This patch adds the defrag step before driver attempts to process > multicast frame(s). > > Signed-off-by: Mahesh Bandewar <maheshb@...gle.com> And now you are potentially modifying the geometry of packets that traverse ipvlan devices. I am sorry but I am going to put my foot down and not allow another instance of this to happen again. We already have this being done by netfilter, and I consider it unacceptable as well as inefficient. If a fragmented frame is going to be forwarded by us, defragmenting and refragmenting may create a different outgoing packet stream than what arrived. If the outgoing interface's MTU can accomodate the incoming frames, this kind of modification is absolutely forbidden. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists