[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <55450464.8060109@plumgrid.com>
Date: Sat, 02 May 2015 10:07:48 -0700
From: Alexei Starovoitov <ast@...mgrid.com>
To: Jesper Dangaard Brouer <brouer@...hat.com>
CC: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
Robert Olsson <robert@...julf.net>,
Ben Greear <greearb@...delatech.com>
Subject: Re: [PATCH v3 net-next] pktgen: introduce 'rx' mode
On 5/2/15 9:46 AM, Jesper Dangaard Brouer wrote:
> Okay, I guess it makes sense as a "mode".
>
> Calling it "stack_inject" is fairly descriptive, but I also like
> Daniel's idea of option "xmit_mode [rx|tx]".
sure. that's fine too.
> I would not allow it to be reconfigured on the fly, but only when the
> test/thread is stopped (!pkt_dev->running), allow re-configuring back
> to "TX" mode. Although, removing (and free) the entire pkt_dev, would
> implicitly reset it back.
all makes sense.
btw, I'm off the grid till Monday and it sounds like you see concrete
spots in the code to hack this stuff in, so if you want to take over,
please go ahead :)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists