netdev - Re: [PATCH] netfilter: fix dependency issues between IPv6 defragmentation and ip6tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150503110715.GE22481@breakpoint.cc>
Date:	Sun, 3 May 2015 13:07:15 +0200
From:	Florian Westphal <fw@...len.de>
To:	Liu Hua <sdu.liu@...wei.com>
Cc:	davem@...emloft.net, kadlec@...ckhole.kfki.hu, kaber@...sh.net,
	pablo@...filter.org, netfilter-devel@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	liusdu@....com
Subject: Re: [PATCH] netfilter: fix dependency issues between IPv6
 defragmentation and ip6tables

Liu Hua <sdu.liu@...wei.com> wrote:
> commit f6318e558806c925029dc101f14874be9f9fa78f fix some related issue
> when ip6tables is enabled. But when IP6_NF_IPTABLES is disabled and
> NETFILTER_XT_TARGET_TPROXY is enabled. We will meet build failure with
> "net/built-in.o: In function `tproxy_tg_init':
> net/netfilter/xt_TPROXY.c:588: undefined reference to `nf_defrag_ipv6_enable'
> "
> So this patch change the Kconfig as ipv4 does.
> --- a/net/netfilter/Kconfig
> +++ b/net/netfilter/Kconfig
> @@ -865,7 +865,7 @@ config NETFILTER_XT_TARGET_TPROXY
>  	depends on (IPV6 || IPV6=n)
>  	depends on IP_NF_MANGLE
>  	select NF_DEFRAG_IPV4
> -	select NF_DEFRAG_IPV6 if IP6_NF_IPTABLES
> +	select NF_DEFRAG_IPV6

If IP6_NF_IPTABLES is not set, why would we have to pick
up IPV6 defragmentation?

Without ip6tables, TPROXY cannot be used for ipv6; in fact;
xt_TPROXY should be built without ipv6 support in this case.

My guess is that you have TPROXY=y but DEFRAG_IPV6=m, but that
might warrant a better fix (xt_socket seems to have same issue).
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html