lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sun, 3 May 2015 15:11:58 -0600
From:	Jεan Sacren <sakiwit@...il.com>
To:	Florian Westphal <fw@...len.de>
Cc:	netdev@...r.kernel.org, Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH net-next] sock: fix comment location

From: Florian Westphal <fw@...len.de>
Date: Sun, 03 May 2015 23:05:34 +0200
>
> Jεan Sacren <sakiwit@...il.com> wrote:
> > From: Jean Sacren <sakiwit@...il.com>
> > 
> > The block of comment is for 'sk_incoming_cpu' rather than 'sk_txhash'.
> > Therefore, move it above "u16 sk_incoming_cpu;" where it belongs.
> 
> comment is at the right place.
> 
> > diff --git a/include/net/sock.h b/include/net/sock.h
> > --- a/include/net/sock.h
> > +++ b/include/net/sock.h
> > -	u16			sk_incoming_cpu;
> >  	/* 16bit hole
> >  	 * Warned : sk_incoming_cpu can be set from softirq,
> >  	 * Do not use this hole without fully understanding possible issues.
> >  	 */
> > +	u16			sk_incoming_cpu;
> 
> This hole is between sk_incoming_cpu and sk_txhash.

I'm so sorry. Thank you for teaching me. I did wish there were an empty
line below "u16 sk_incoming_cpu;"
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists