netdev - Re: [RFC PATCH net-next v3 3/9] ipv6: Combine rt6_alloc_cow and rt6_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150504170826.GH2731450@devbig242.prn2.facebook.com>
Date:	Mon, 4 May 2015 10:08:27 -0700
From:	Martin KaFai Lau <kafai@...com>
To:	netdev <netdev@...r.kernel.org>
CC:	Hannes Frederic Sowa <hannes@...essinduktion.org>,
	Steffen Klassert <steffen.klassert@...unet.com>,
	Julian Anastasov <ja@....bg>,
	David Miller <davem@...emloft.net>,
	Kernel Team <Kernel-team@...com>
Subject: Re: [RFC PATCH net-next v3 3/9] ipv6: Combine rt6_alloc_cow and
 rt6_alloc_clone

On Fri, May 01, 2015 at 05:26:52PM -0700, Martin KaFai Lau wrote:
>  static struct rt6_info *ip6_pol_route(struct net *net, struct fib6_table *table, int oif,
>  				      struct flowi6 *fl6, int flags)
>  {
> @@ -918,10 +914,9 @@ redo_rt6_select:
>  	if (rt->rt6i_flags & RTF_CACHE)
>  		goto out2;
>  
> -	if (!(rt->rt6i_flags & (RTF_NONEXTHOP | RTF_GATEWAY)))
> -		nrt = rt6_alloc_cow(rt, &fl6->daddr, &fl6->saddr);
> -	else if (!(rt->dst.flags & DST_HOST) || !(rt->dst.flags & RTF_LOCAL))
> -		nrt = rt6_alloc_clone(rt, &fl6->daddr);
> +	if (!rt6_is_gw_or_nonexthop(rt) ||
> +	    !(rt->dst.flags & DST_HOST) || !(rt->dst.flags & RTF_LOCAL))
It inherited a similar typo here which has already been fixed in net-next.
rt->dst.flags instead of rt->rt6i_flags is used when checking the RTF_LOCAL
flag.  The other patches are still good for review purpose.  I will re-post this
series later.

--Martin
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html