netdev - Re: [PATCH 5/7] ip-route: don't hide routes with RTM_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150504.143708.1105742826058228400.davem@davemloft.net>
Date:	Mon, 04 May 2015 14:37:08 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	stephen@...workplumber.org
Cc:	pavlix@...lix.net, netdev@...r.kernel.org, psimerda@...hat.com
Subject: Re: [PATCH 5/7] ip-route: don't hide routes with RTM_F_CLONED by
 default

From: Stephen Hemminger <stephen@...workplumber.org>
Date: Mon, 4 May 2015 08:37:51 -0700

> On Mon, 13 Apr 2015 16:00:59 +0200
> Pavel Šimerda <pavlix@...lix.net> wrote:
> 
>> From: Pavel Šimerda <psimerda@...hat.com>
>> 
>> Signed-off-by: Pavel Šimerda <psimerda@...hat.com>
>> ---
>>  ip/iproute.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> I understand your concern, and it probably was a poor design choice initially.
> 
> Since this will change the output for the default case, it will upset some
> peoples expectations and potentially break scripts that screen scrape the output
> of ip commands. Therefore I can't accept it at this time.
> 
> Sorry for the delay, but I thought someone else would add more comments.
> Perhaps if you explained in more detail the motivation of why this is an
> important problem I would reconsider change the behavior.

We definitely need to report routes created by caching/cloning separately
from the main FIB entries.

And I agree that even if we wanted to change behavior, the horse has
already left the barn on this one and therefore there is no way we can
change this now.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html