netdev - Re: [PATCH net-next 0/5] tipc: cleanup topology server

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150504.150513.980672757479761618.davem@davemloft.net>
Date:	Mon, 04 May 2015 15:05:13 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ying.xue@...driver.com
Cc:	jon.maloy@...csson.com, Paul.Gortmaker@...driver.com,
	erik.hugne@...csson.com, netdev@...r.kernel.org,
	tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net-next 0/5] tipc: cleanup topology server

From: Ying Xue <ying.xue@...driver.com>
Date: Mon, 4 May 2015 10:36:43 +0800

> Not only function names declared in subscr.c are very confused, but
> also topology server's locking policy is not designed very well, for
> instance, usually leading to panic in some special corner cases.
> 
> In this series, we attempt to eliminate the confusion of function names
> and simplify topology server's locking policy to solve above mentioned
> issues. More importantly, the change will make relevant code easily
> understandable and maintainable.

Series applied, thanks.

I think the "void *" cast of the return value from
tipc_subscrb_connect_cb() is completely unnecessary.  All casts to and
from void are implicit in C.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html