netdev - Re: [PATCH 0/4] Netfilter ingress support (v3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150504230414.GB8279@pox.localdomain>
Date:	Tue, 5 May 2015 01:04:14 +0200
From:	Thomas Graf <tgraf@...g.ch>
To:	Pablo Neira Ayuso <pablo@...filter.org>
Cc:	Alexei Starovoitov <alexei.starovoitov@...il.com>,
	Florian Westphal <fw@...len.de>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	netfilter-devel@...r.kernel.org, davem@...emloft.net,
	netdev@...r.kernel.org, kaber@...sh.net
Subject: Re: [PATCH 0/4] Netfilter ingress support (v3)

On 05/05/15 at 12:21am, Pablo Neira Ayuso wrote:
> On Mon, May 04, 2015 at 01:05:08PM -0700, Alexei Starovoitov wrote:
> > [...] TC critical path becomes slower with extra dereference and
> > indirect jump.
> 
> You complained on the performance impact of the initial generic hook
> infrastructure that allows qdisc ingress and nft to co-exist, fair
> enough.
> 
> I came back with an even more simple hook infrastructure, to address
> performance concerns, and you indicate that an *extra dereference and
> indirect jump* makes this slowier and that both cannot co-exist with
> this.
> 
> Well, any kind of hook generalization will need at least those minimal
> changes. And that allows us to move code that belongs to sch_ingress.
> That got embedded into net/core/dev.c because at the time this code
> was made when there was no RCU around.

Does anything speak against a separate hook with a static key?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html