netdev - Re: [PATCH next v2 2/3] ipvlan: Process fragmented multicast frames correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150504.192214.583143462067773210.davem@davemloft.net>
Date:	Mon, 04 May 2015 19:22:14 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	maheshb@...gle.com
Cc:	netdev@...r.kernel.org, edumazet@...gle.com, dcbw@...hat.com
Subject: Re: [PATCH next v2 2/3] ipvlan: Process fragmented multicast
 frames correctly

From: Mahesh Bandewar <maheshb@...gle.com>
Date: Mon, 4 May 2015 15:58:59 -0700

> On Fri, May 1, 2015 at 6:12 PM, David Miller <davem@...emloft.net> wrote:
>> I am sorry but I am going to put my foot down and not allow another
>> instance of this to happen again.  We already have this being done by
>> netfilter, and I consider it unacceptable as well as inefficient.
>>
> Actually this will make the fragments processing more efficient. e.g.
> if there are 50 slave devices and we receive 10 fragments, the
> duplication will happen for 50*10 = 500 skbs but if the packet is
> defragmented, then it's only once per device making it more efficient.

You can linearize it 'zero' times, which is more efficient than
anything no matter how many interfaces.

And you can do this by maintaining a chain of the incoming SKBs and
then resegmenting them, which allows to maintain exactly the precise
geometry you started with in a guaranteed way.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html