netdev - Re: [PATCH v2] net/rds: fix unaligned memory access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150503.233919.1745167313833037648.davem@davemloft.net>
Date:	Sun, 03 May 2015 23:39:19 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	david.ahern@...cle.com
Cc:	rds-devel@....oracle.com, netdev@...r.kernel.org,
	shamir.rabinovitch@...cle.com
Subject: Re: [PATCH v2] net/rds: fix unaligned memory access

From: David Ahern <david.ahern@...cle.com>
Date: Thu, 30 Apr 2015 20:58:07 -0400

> From: shamir rabinovitch <shamir.rabinovitch@...cle.com>
> 
> rdma_conn_param private data is copied using memcpy after headers such
> as cma_hdr (see cma_resolve_ib_udp as example). so the start of the
> private data is aligned to the end of the structure that come before. if
> this structure end with u32 the meaning is that the start of the private
> data will be 4 bytes aligned. structures that use u8/u16/u32/u64 are
> naturally aligned but in case the structure start is not 8 bytes aligned,
> all u64 members of this structure will not be aligned. to solve this issue
> we must use special macros that allow unaligned access to those
> unaligned members.
> 
> Addresses the following kernel log seen when attempting to use RDMA:
> 
> Kernel unaligned access at TPC[10507a88] rds_ib_cm_connect_complete+0x1bc/0x1e0 [rds_rdma]
> 
> Acked-by: Chien Yen <chien.yen@...cle.com>
> Signed-off-by: shamir rabinovitch <shamir.rabinovitch@...cle.com>
> [Minor tweaks for top of tree by:]
> Signed-off-by: David Ahern <david.ahern@...cle.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html