netdev - Re: [PATCH v2 net-next 0/7] net: Eliminate calls to flow_dissector and introduce flow_keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150504.000936.1447145169083187732.davem@davemloft.net>
Date:	Mon, 04 May 2015 00:09:36 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	tom@...bertland.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 0/7] net: Eliminate calls to flow_dissector
 and introduce flow_keys_digest

From: Tom Herbert <tom@...bertland.com>
Date: Fri, 1 May 2015 11:30:11 -0700

> In this patch set we add skb_get_hash_perturb which gets the skbuff
> hash for a packet and perturbs it using a provided key and jhash1.
> This function is used in serveral qdiscs and eliminates many calls
> to flow_dissector and jhash3 to get a perturbed hash for a packet.
> 
> To handle the sch_choke issue (passes flow_keys in skbuff cb) we
> add flow_keys_digest which is a digest of a flow constructed
> from a flow_keys structure.
> 
> This is the second version of these patches I posted a while ago,
> and is prerequisite work to increasing the size of the flow_keys
> structure and hashing over it (full IPv6 address, flow label, VLAN ID,
> etc.).
> 
> Version 2:
> 
> - Add keyval parameter to __flow_hash_from_keys which allows caller to
>   set the initval for jhash
> - Perturb always does flow dissection and creates hash based on
>   input perturb value which acts as the keyval to __flow_hash_from_keys
> - Added a _flow_keys_digest_data which is used in make_flow_keys_digest.
>   This fills out the digest by populating individual fields instead
>   of copying the whole structure.

Series applied, thanks Tom.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html