netdev - Re: [PATCH net-next v5 20/21] rocker: make checkpatch -f clean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 05 May 2015 11:22:56 -0700
From:	Joe Perches <joe@...ches.com>
To:	sfeldma@...il.com
Cc:	netdev@...r.kernel.org, jiri@...nulli.us,
	roopa@...ulusnetworks.com, linux@...ck-us.net,
	f.fainelli@...il.com, sridhar.samudrala@...el.com,
	ronen.arad@...el.com, andrew@...n.ch, simon.horman@...ronome.com
Subject: Re: [PATCH net-next v5 20/21] rocker: make checkpatch -f clean

On Tue, 2015-05-05 at 10:34 -0700, sfeldma@...il.com wrote:
[]
> diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c

trivia:

> @@ -4699,8 +4704,9 @@ static int rocker_port_poll_tx(struct napi_struct *napi, int budget)
>  		if (err == 0) {
>  			rocker_port->dev->stats.tx_packets++;
>  			rocker_port->dev->stats.tx_bytes += skb->len;
> -		} else
> +		} else {
>  			rocker_port->dev->stats.tx_errors++;
> +		}

This might be sped up a bit with a likely

		if (likely(!err)) {
			rocker_port->dev->stats.tx_packets++;
			rocker_port->dev->stats.tx_bytes += skb->len;
		} else {
			rocker_port->dev->stats.tx_errors++;
		}


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html