netdev - Re: [PATCH] ipv6: RTA_PREFSRC dumping was somewhat incorrect.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 05 May 2015 16:56:11 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	markus.stenberg@....fi
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ipv6: RTA_PREFSRC dumping was somewhat incorrect.

From: Markus Stenberg <markus.stenberg@....fi>
Date: Mon, 4 May 2015 14:46:02 +0300

> Avoid dumping RTA_PREFSRC twice if iif is not set, but dst is.
> 
> Note that the change also dumps RTA_PREFSRC even if iif RTA_IIF is
> sent. As scopes are not that rare in IPv6, I believe that to be
> correct behavior.
> 
> Signed-off-by: Markus Stenberg <markus.stenberg@....fi>

The distinguishing characteristic that should decide whether we
provide a PREFSRC or not is whether this route is an output route
or not.

Neither the current logic, nor your patch, implements this.

But that's what this code needs to do.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html