netdev - Re: [PATCH v3] adm8211: fix checkpatch error for trailing statements on next line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 04 May 2015 23:44:58 -0700
From:	Joe Perches <joe@...ches.com>
To:	Okash Khawaja <okash.khawaja@...il.com>
Cc:	kvalo@...eaurora.org, linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] adm8211: fix checkpatch error for trailing
 statements on next line

On Tue, 2015-05-05 at 07:01 +0100, Okash Khawaja wrote:
> This patch fixes the checkpatch.pl error:

Please fix the space/tab use too.

Your email client seems to have converted all the tabs
to spaces.

default should use the same indent as the case statements


> diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c
[]
> @@ -1098,14 +1098,18 @@ static void adm8211_hw_init(struct ieee80211_hw *dev)
>                 pci_read_config_byte(priv->pdev, PCI_CACHE_LINE_SIZE, &cline);
>  
>                 switch (cline) {
> -               case  0x8: reg |= (0x1 << 14);
> -                          break;
> -               case 0x16: reg |= (0x2 << 14);
> -                          break;
> -               case 0x32: reg |= (0x3 << 14);
> -                          break;
> -                 default: reg |= (0x0 << 14);
> -                          break;
> +               case  0x8:
> +                       reg |= (0x1 << 14);
> +                       break;
> +               case 0x16:
> +                       reg |= (0x2 << 14);
> +                       break;
> +               case 0x32:
> +                       reg |= (0x3 << 14);
> +                       break;
> +                 default:
> +                       reg |= (0x0 << 14);
> +                       break;
>                 }
>         }
>  

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html