netdev - Re: [V2 PATCH 2/5] arm64 : Introduce support for ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 May 2015 11:09:38 -0500
From:	Suravee Suthikulanit <suravee.suthikulpanit@....com>
To:	Arnd Bergmann <arnd@...db.de>,
	<linux-arm-kernel@...ts.infradead.org>
CC:	<rjw@...ysocki.net>, <lenb@...nel.org>, <catalin.marinas@....com>,
	<will.deacon@....com>, <thomas.lendacky@....com>,
	<herbert@...dor.apana.org.au>, <davem@...emloft.net>,
	<al.stone@...aro.org>, <linaro-acpi@...ts.linaro.org>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-acpi@...r.kernel.org>, <leo.duran@....com>,
	<hanjun.guo@...aro.org>, <msalter@...hat.com>,
	<grant.likely@...aro.org>, <linux-crypto@...r.kernel.org>
Subject: Re: [V2 PATCH 2/5] arm64 : Introduce support for ACPI _CCA object

On 5/5/2015 10:44 AM, Arnd Bergmann wrote:
> On Tuesday 05 May 2015 10:12:06 Suravee Suthikulpanit wrote:
>> +struct dma_map_ops dummy_dma_ops = {
>> +       .alloc                  = __dummy_alloc,
>> +       .free                   = __dummy_free,
>> +       .mmap                   = __dummy_mmap,
>> +       .map_page               = __dummy_map_page,
>> +       .unmap_page             = __dummy_unmap_page,
>> +       .map_sg                 = __dummy_map_sg,
>> +       .unmap_sg               = __dummy_unmap_sg,
>> +       .sync_single_for_cpu    = __dummy_sync_single_for_cpu,
>> +       .sync_single_for_device = __dummy_sync_single_for_device,
>> +       .sync_sg_for_cpu        = __dummy_sync_sg_for_cpu,
>> +       .sync_sg_for_device     = __dummy_sync_sg_for_device,
>> +       .mapping_error          = __dummy_mapping_error,
>> +       .dma_supported          = __dummy_dma_supported,
>> +};
>> +EXPORT_SYMBOL(dummy_dma_ops);
>> +
>>
>
> This will clearly work, but I think it's easier to just leave
> the dma_mask pointer as NULL when creating the platform device,
> which should let the normal dma ops fail all the callbacks.
>
> 	Arnd
>

However, codes in several places are making use of dma_map_ops without 
checking if the ops are NULL (i.e. 
include/asm-generic/dma-mapping-common.h and in arch-specific 
implementation). If setting it to NULL is what we are planning to 
support, we would need to scrub the current code to put NULL check. 
Also, would you consider if that is safe to do going forward?

Thanks,
Suravee

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html