netdev - Re: [PATCH net-next] switchdev: add support for fdb add/del/dump via switchdev_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <554AA530.7000702@mojatatu.com>
Date:	Wed, 06 May 2015 19:35:12 -0400
From:	Jamal Hadi Salim <jhs@...atatu.com>
To:	Sridhar Samudrala <sridhar.samudrala@...el.com>, sfeldma@...il.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] switchdev: add support for fdb add/del/dump
 via switchdev_port_obj ops.

On 05/06/15 17:54, Sridhar Samudrala wrote:
> - introduce port fdb obj and generic switchdev_port_fdb_add/del/dump()
> - use switchdev_port_fdb_add/del/dump in rocker/team/bonding ndo ops.
> - add support for fdb obj in switchdev_port_obj_add/del/dump()
> - switch rocker to implement fdb ops via switchdev_ops
>
> Signed-off-by: Sridhar Samudrala <sridhar.samudrala@...el.com>
> Signed-off-by: Scott Feldman <sfeldma@...il.com>
> ---



So i raised this earlier. DaveM also chimed in - but it seems still
in there.
i havent been following the discussion and i may have missed
the agreement to keep the new IDs. Could we not just have used netlink
  IDs (as opposed to a new SWITCHDEV_OBJ_PORT_FDB id)?

> +int switchdev_port_fdb_add(struct ndmsg *ndm, struct nlattr *tb[],
> +			   struct net_device *dev, const unsigned char *addr,
> +			   u16 vid, u16 nlm_flags)
> +{
> +	struct switchdev_obj obj = {
> +		.id = SWITCHDEV_OBJ_PORT_FDB,
> +		.fdb = {
> +			.addr = addr,
> +			.vid = vid,
> +		},
> +	};
> +
> +	return switchdev_port_obj_add(dev, &obj);
> +}

cheers,
jamal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html