netdev - Re: [PATCH net-next 4/6] netns: notify new nsid outside _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <554A19A8.1080304@6wind.com>
Date:	Wed, 06 May 2015 15:39:52 +0200
From:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:	Thomas Graf <tgraf@...g.ch>
CC:	netdev@...r.kernel.org, davem@...emloft.net, ebiederm@...ssion.com
Subject: Re: [PATCH net-next 4/6] netns: notify new nsid outside __peernet2id()

Le 06/05/2015 13:48, Thomas Graf a écrit :
[snip]
>
> Since you need the allocation behaviour from one call site only it
> might be cleaner to add a __peernet2id_alloc() which is used from
> the old __peernet2id() so you can call __peernet2id_alloc() from
> peernet2id_alloc() and avoid putting these ugly bool alloc = false
> in all other call sites.
You're absolutely right.

Side note:

bool false = false;
...
__peernet2id_alloc(net, peer, &false);

This compiles but the behavior is unexpected. In __peernet2id_alloc() the bool
is true. I need to think a bit more to explain that.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html