netdev - Re: [PATCH net-next v5 03/21] switchdev: introduce get/set attrs ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150506031154.GA1992@nanopsycho>
Date:	Wed, 6 May 2015 05:11:54 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	sfeldma@...il.com
Cc:	netdev@...r.kernel.org, roopa@...ulusnetworks.com,
	linux@...ck-us.net, f.fainelli@...il.com,
	sridhar.samudrala@...el.com, ronen.arad@...el.com, andrew@...n.ch,
	simon.horman@...ronome.com
Subject: Re: [PATCH net-next v5 03/21] switchdev: introduce get/set attrs ops

Tue, May 05, 2015 at 07:34:39PM CEST, sfeldma@...il.com wrote:
>From: Scott Feldman <sfeldma@...il.com>
>
>Add two new swdev ops for get/set switch port attributes.  Most swdev
>interactions on a port are gets or sets on port attributes, so rather than
>adding ops for each attribute, let's define clean get/set ops for all
>attributes, and then we can have clear, consistent rules on how attributes
>propagate on stacked devs.
>
>Add the basic algorithms for get/set attr ops.  Use the same recusive algo
>to walk lower devs we've used for STP updates, for example.  For get,
>compare attr value for each lower dev and only return success if attr
>values match across all lower devs.  For sets, set the same attr value for
>all lower devs.  We'll use a two-phase prepare-commit transaction model for
>sets.  In the first phase, the driver(s) are asked if attr set is OK.  If
>all OK, the commit attr set in second phase.  A driver would NACK the
>prepare phase if it can't set the attr due to lack of resources or support,
>within it's control.  RTNL lock must be held across both phases because
>we'll recurse all lower devs first in prepare phase, and then recurse all
>lower devs again in commit phase.  If any lower dev fails the prepare
>phase, we need to abort the transaction for all lower devs.
>
>If lower dev recusion isn't desired, allow a flag SWITCHDEV_F_NO_RECURSE to
>indicate get/set only work on port (lowest) device.
>
>Signed-off-by: Scott Feldman <sfeldma@...il.com>

Acked-by: Jiri Pirko <jiri@...nulli.us>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html