netdev - [PATCH RFC 0/2] stmmac: stand alone platform drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu,  7 May 2015 20:19:23 +0200
From:	Joachim Eastwood <manabian@...il.com>
To:	arnd@...db.de
Cc:	peppe.cavallaro@...com, netdev@...r.kernel.org,
	davem@...emloft.net, linux-arm-kernel@...ts.infradead.org,
	Joachim Eastwood <manabian@...il.com>
Subject: [PATCH RFC 0/2] stmmac: stand alone platform drivers

Hi Arnd,

I ran into some issue using a separate platform driver[1] for lpc1850-dwmac.

My dts files looks like this.
mac: ethernet@...10000 {
	compatible = "nxp,lpc1850-dwmac", "snps,dwmac-3.611", "snps,dwmac";
	...
}

On boot the generic driver in stmmac_platform.c would grab the
device, matching on one of generic compat strings and thus blocking
the lpc1850-dwmac driver.

By changing the build order in the Makefile (see patch 1) I managed
to get it working, but I am not sure that is a good solution(?).

Another fix would be to remove the generic compat strings from the
match table in stmmac_platform but there are some dts-files that
only have these compat strings.
See abilis_tb10x.dtsi and exynos5440.dtsi.

I could also remove the generic compat strings from my dts file but
I am not sure that is good solution either. If more glue is
converted this would then be need in those dts files also.

Any advice on how to handle this situation?

[1] http://marc.info/?l=linux-arm-kernel&m=143076781409270&w=2

Joachim Eastwood (2):
  stmac: support standalone platform drivers
  stmac: add dwmac glue for NXP 18xx/43xx family

 drivers/net/ethernet/stmicro/stmmac/Makefile       | 11 ++-
 .../net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c    | 98 ++++++++++++++++++++++
 .../net/ethernet/stmicro/stmmac/stmmac_platform.c  | 14 ++--
 .../net/ethernet/stmicro/stmmac/stmmac_platform.h  |  4 +
 4 files changed, 120 insertions(+), 7 deletions(-)
 create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c

-- 
1.8.0

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html