[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <B5657A6538887040AD3A81F1008BEC63D7C945@AVMB1.qlogic.org>
Date: Thu, 7 May 2015 19:03:07 +0000
From: Yuval Mintz <Yuval.Mintz@...gic.com>
To: Michal Schmidt <mschmidt@...hat.com>,
netdev <netdev@...r.kernel.org>
CC: David Miller <davem@...emloft.net>
Subject: RE: [PATCH net] bnx2x: limit fw delay in kdump to 5s after boot
> + if (is_kdump_kernel()) {
> + ktime_t now = ktime_get_boottime();
> + ktime_t fw_ready_time = ktime_set(5, 0);
> +
> + if (ktime_before(now, fw_ready_time))
> + msleep(ktime_ms_delta(fw_ready_time, now));
Can't really say I'm familiar with these APIs , but what about the lower
msleep limit (is 20 or 50 milliseconds today?)?
Shouldn't there be an msleep variant that's good for such cases?
[Or is it a non-issue, since at most msleep will be inaccurate]
Regardless, the patch itself looks good.
> + }--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists