netdev - Re: [RFC PATCH net-next 00/11] netns: don't switch namespace while creating kernel sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHA+R7N9BuJGnA1r_K886pr45EP6ry85T2pbr2u8neJs-ROrYw@mail.gmail.com>
Date:	Thu, 7 May 2015 12:29:55 -0700
From:	Cong Wang <cwang@...pensource.com>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	Ying Xue <ying.xue@...driver.com>, netdev <netdev@...r.kernel.org>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Pavel Emelyanov <xemul@...nvz.org>,
	David Miller <davem@...emloft.net>,
	Eric Dumazet <eric.dumazet@...il.com>, maxk@....qualcomm.com,
	Stephen Hemminger <stephen@...workplumber.org>,
	Thomas Graf <tgraf@...g.ch>,
	Nicolas Dichtel <nicolas.dichtel@...nd.com>,
	Tom Herbert <tom@...bertland.com>,
	James Chapman <jchapman@...alix.com>,
	Erik Hugne <erik.hugne@...csson.com>, jon.maloy@...csson.com,
	Simon Horman <horms@...ge.net.au>
Subject: Re: [RFC PATCH net-next 00/11] netns: don't switch namespace while
 creating kernel sockets

On Thu, May 7, 2015 at 11:58 AM, Eric W. Biederman
<ebiederm@...ssion.com> wrote:
> Cong Wang <cwang@...pensource.com> writes:
>
>> On Thu, May 7, 2015 at 11:26 AM, Eric W. Biederman
>> <ebiederm@...ssion.com> wrote:
>>> Cong Wang <cwang@...pensource.com> writes:
>>>
>>>>
>>>> Why does this have to be so complicated? We can simply avoid
>>>> calling ops_init() by skipping those in cleanup_list, no?
>>>
>>> The problem is that there is a single list of methods to call and if you
>>> simply skip calling the initialization methods for a struct net and add
>>> yourself to the list cleanup_net will then call the cleanup methods
>>> without calling the cleanup methods.
>>
>> If you mean pernet_list, ops->list has been already added before
>> for_each_net().
>>
>>>
>>> Simply limiting new network namespace registrations to a point when
>>> network namespaces are not being registered or unregisted seems like
>>> the simplest way to achieve this effect.
>>>
>>
>> Literally, any point before ops_init().
>
> Think about what that what it means to add a set of operations to the
> pernet_list and then to skip a network namespace with a count of 0 and
> then to have that network namespace exit with those methods on
> pernet_list.
>

That is easy to solve, isn't it?

diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c
index 78fc04a..d2af11e 100644
--- a/net/core/net_namespace.c
+++ b/net/core/net_namespace.c
@@ -242,6 +242,7 @@ static __net_init int setup_net(struct net *net,
struct user_namespace *user_ns)
        net->dev_base_seq = 1;
        net->user_ns = user_ns;
        idr_init(&net->netns_ids);
+       INIT_LIST_HEAD(&net->cleanup_list);

        list_for_each_entry(ops, &pernet_list, list) {
                error = ops_init(ops, net);
@@ -734,20 +735,21 @@ static int __register_pernet_operations(struct
list_head *list,
        int error;
        LIST_HEAD(net_exit_list);

-       list_add_tail(&ops->list, list);
        if (ops->init || (ops->id && ops->size)) {
                for_each_net(net) {
+                       if (!list_empty(&net->cleanup_list))
+                               continue;
                        error = ops_init(ops, net);
                        if (error)
                                goto out_undo;
                        list_add_tail(&net->exit_list, &net_exit_list);
                }
        }
+       list_add_tail(&ops->list, list);
        return 0;

 out_undo:
        /* If I have an error cleanup all namespaces I initialized */
-       list_del(&ops->list);
        ops_exit_list(ops, &net_exit_list);
        ops_free_list(ops, &net_exit_list);
        return error;


The problem with your approach is that the code is over complicated,
the netns core code is already too complicated. ;)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html