netdev - Re: [PATCH net-next] switchdev: add support for fdb add/del/dump via switchdev_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <554B5FE6.90507@cumulusnetworks.com>
Date:	Thu, 07 May 2015 05:51:50 -0700
From:	roopa <roopa@...ulusnetworks.com>
To:	"Samudrala, Sridhar" <sridhar.samudrala@...el.com>
CC:	Jamal Hadi Salim <jhs@...atatu.com>, sfeldma@...il.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] switchdev: add support for fdb add/del/dump
 via switchdev_port_obj ops.

On 5/6/15, 9:42 PM, Samudrala, Sridhar wrote:
>
>
> On 5/6/2015 4:35 PM, Jamal Hadi Salim wrote:
>> On 05/06/15 17:54, Sridhar Samudrala wrote:
>>> - introduce port fdb obj and generic switchdev_port_fdb_add/del/dump()
>>> - use switchdev_port_fdb_add/del/dump in rocker/team/bonding ndo ops.
>>> - add support for fdb obj in switchdev_port_obj_add/del/dump()
>>> - switch rocker to implement fdb ops via switchdev_ops
>>>
>>> Signed-off-by: Sridhar Samudrala <sridhar.samudrala@...el.com>
>>> Signed-off-by: Scott Feldman <sfeldma@...il.com>
>>> ---
>>
>> So i raised this earlier. DaveM also chimed in - but it seems still
>> in there.
>> i havent been following the discussion and i may have missed
>> the agreement to keep the new IDs. Could we not just have used netlink
>>  IDs (as opposed to a new SWITCHDEV_OBJ_PORT_FDB id)?
>
> I think you are referring to switch port attributes.  See Scott's 
> response here on
> using netlink IDs for attributes.
> http://thread.gmane.org/gmane.linux.network/357694/focus=357921
>
If you are using a global namespace for all switchdev objects/apis (as 
with scotts new patches), yes, using existing netlink id's and 
structures will not work as scott mentions in the link you point to 
above. But, if you were designing the api's for specific networking 
subsystems like it was initially, then netlink id's or existing 
structures will work.

And i am guessing Jamal is referring to the latter.

I did raise similar concerns earlier. Scotts patches do make the code 
way cleaner and less confusing than it was before (Thanks scott!). But, 
It does add this additional layer of mapping between kernel 
structures/objects and newly introduced switchdev structures/objects. 
The advantage of being in the kernel is access to existing kernel 
structures/objects. We lose that benefit.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html