netdev - Re: [PATCH] net: fec: add support of ethtool get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 9 May 2015 18:59:01 -0300
From:	Fabio Estevam <festevam@...il.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Philippe Reynes <tremyfr@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Duan Fugang-B38611 <B38611@...escale.com>,
	Frank Li <Frank.Li@...escale.com>,
	Lothar Waßmann <LW@...o-electronics.de>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: fec: add support of ethtool get_regs

Philippe,

On Sat, May 9, 2015 at 6:17 PM, Russell King - ARM Linux
<linux@....linux.org.uk> wrote:

> Using memcpy_fromio() to copy device registers is not a good idea -
> it can use a variable access size which can cause bus faults.

An example on how memcpy_fromio() can be avoided in get_regs:
drivers/net/ethernet/samsung/sxgbe/sxgbe_ethtool.c

Regards,

Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html