netdev - Re: [PATCH -next] net: sched: use counter to break reclassify loops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150511203006.GA2914@Alexeis-MacBook-Pro.local>
Date:	Mon, 11 May 2015 13:30:07 -0700
From:	Alexei Starovoitov <alexei.starovoitov@...il.com>
To:	Florian Westphal <fw@...len.de>
Cc:	netdev@...r.kernel.org, jhs@...atatu.com
Subject: Re: [PATCH -next] net: sched: use counter to break reclassify loops

On Mon, May 11, 2015 at 07:50:41PM +0200, Florian Westphal wrote:
> Seems all we want here is to avoid endless 'goto reclassify' loop.
> tc_classify_compat even resets this counter when something other
> than TC_ACT_RECLASSIFY is returned, so this skb-counter doesn't
> break hypothetical loops induced by something other than perpetual
> TC_ACT_RECLASSIFY return values.
> 
> skb_act_clone is now identical to skb_clone, so just use that.
> 
> Tested with following (bogus) filter:
> tc filter add dev eth0 parent ffff: \
>  protocol ip u32 match u32 0 0 police rate 10Kbit burst \
>  64000 mtu 1500 action reclassify
> 
> Acked-by: Daniel Borkmann <daniel@...earbox.net>
> Signed-off-by: Florian Westphal <fw@...len.de>

agree. that's my reading of the code as well.
Acked-by: Alexei Starovoitov <ast@...mgrid.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html