netdev - Re: [PATCH net] xen/netback: Properly initialize credit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 11 May 2015 23:45:39 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Ross Lagerwall <ross.lagerwall@...rix.com>, netdev@...r.kernel.org
CC:	wei.liu2@...rix.com
Subject: Re: [PATCH net] xen/netback: Properly initialize credit_bytes

Hello.

On 05/11/2015 08:04 PM, Ross Lagerwall wrote:

> Commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into queue
> struct") introduced a regression when moving queue-specific data into
> the queue struct by failing to set the credit_bytes field. This
> prevented bandwidth limiting from working. Initialize the field as it
> was done before multiqueue support was added.

> Signed-off-by: Ross Lagerwall <ross.lagerwall@...rix.com>
> Acked-by: Wei Liu <wei.liu2@...rix.com>
> ---
>   drivers/net/xen-netback/xenbus.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c
> index 3d8dbf5..1be3ef3 100644
> --- a/drivers/net/xen-netback/xenbus.c
> +++ b/drivers/net/xen-netback/xenbus.c
> @@ -793,7 +793,7 @@ static void connect(struct backend_info *be)
>   			goto err;
>   		}
>
> -		queue->remaining_credit = credit_bytes;
> +		queue->remaining_credit = queue->credit_bytes = credit_bytes;

[headless@...ted linux]$ scripts/checkpatch.pl 
~/patches/xen_netback-Properly-initialize-credit_bytes.patch
CHECK: multiple assignments should be avoided
#22: FILE: drivers/net/xen-netback/xenbus.c:796:
+		queue->remaining_credit = queue->credit_bytes = credit_bytes;

total: 0 errors, 0 warnings, 1 checks, 8 lines checked

/home/headless/patches/xen_netback-Properly-initialize-credit_bytes.patch has 
style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html