netdev - RE: [PATCH net-next v7 24/24] switchdev: bring documentation up-to-date

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9B0331B6EBBD0E4684FBFAEDA55776F9193B7848@HASMSX110.ger.corp.intel.com>
Date:	Mon, 11 May 2015 21:02:16 +0000
From:	"Rosen, Rami" <rami.rosen@...el.com>
To:	"sfeldma@...il.com" <sfeldma@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	"jiri@...nulli.us" <jiri@...nulli.us>,
	"roopa@...ulusnetworks.com" <roopa@...ulusnetworks.com>,
	"linux@...ck-us.net" <linux@...ck-us.net>,
	"f.fainelli@...il.com" <f.fainelli@...il.com>,
	"andrew@...n.ch" <andrew@...n.ch>,
	"simon.horman@...ronome.com" <simon.horman@...ronome.com>,
	"joe@...ches.com" <joe@...ches.com>,
	"Samudrala, Sridhar" <sridhar.samudrala@...el.com>,
	"Arad, Ronen" <ronen.arad@...el.com>
Subject: RE: [PATCH net-next v7 24/24] switchdev: bring documentation
 up-to-date

Thanks for the good work.

Minor comments:
>+	bridge fdb add ADDR dev DEV [vlan VID] [self]

I suggest consider adding in this section: 
 XXX: what should be done if offloading this rule to hardware fails (for example, due to full capacity in hardware tables) ? 

Apart from it, two typos:

>particularly useful for dynically-named ports where the device names
Should be: dynamically-named ports.

> resposible for partitioning hardware to preserve netns containment
Should be: responsible.

Regards,
Rami Rosen
Intel Corporation