netdev - Re: [PATCH net-next 0/2] handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHA+R7Od3WWS+sM0cr7=4YEB4qMiY61dfrfH_+Eeayi=LxzEsw@mail.gmail.com>
Date:	Mon, 11 May 2015 15:03:51 -0700
From:	Cong Wang <cwang@...pensource.com>
To:	David Miller <davem@...emloft.net>
Cc:	Pablo Neira Ayuso <pablo@...filter.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	Alexei Starovoitov <ast@...mgrid.com>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 0/2] handle_ing update

On Mon, May 11, 2015 at 8:09 AM, David Miller <davem@...emloft.net> wrote:
> There is no difference between having ingress qdisc hanging off of
> netdevice vs. the classifier list.  They both serve the same purpose
> and the change to use the classifier list merely removes one level
> of indirection.

With adding 8 bytes to each of the netdevice even when it doesn't
have ingress qdisc attached at all...

Also breaks the abstraction of Qdisc's which potentially breaks
existing or future code, since now we have two different *layers* to
hold tp_proto.

BTW, it should be protected by CONFIG_NET_SCH_INGRESS
rather than CONFIG_NET_CLS_ACT.

>
> I also am confident that the cost for non-users is equivalent before
> and after this patch series.  Or at least, it very much should be.

If people really cared about ingress qdisc, that spinlock should have
gone much earlier than in 4.x release, rather than waiting for me to
remind.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html