netdev - Re: [PATCH] xfrm: fix a possible policy leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 11 May 2015 13:03:13 +0200
From:	Steffen Klassert <steffen.klassert@...unet.com>
To:	<roy.qing.li@...il.com>
CC:	<netdev@...r.kernel.org>, <eparis@...hat.com>
Subject: Re: [PATCH] xfrm: fix a possible policy leak

On Fri, May 08, 2015 at 05:39:39PM +0800, roy.qing.li@...il.com wrote:
> From: Li RongQing <roy.qing.li@...il.com>
> 
> policy should be put if exit xfrm_policy_bysel_ctx() due to the
> failure of calling security_xfrm_policy_delete. since policy has
> been hold before
> 
> Fixes: ef41aaa0b7 [IPSEC]: xfrm_policy delete security check misplaced
> Signed-off-by: Li RongQing <roy.qing.li@...il.com>
> Cc: Eric Paris <eparis@...hat.com>
> ---
>  net/xfrm/xfrm_policy.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
> index 3d264e5..66450c3 100644
> --- a/net/xfrm/xfrm_policy.c
> +++ b/net/xfrm/xfrm_policy.c
> @@ -824,6 +824,7 @@ struct xfrm_policy *xfrm_policy_bysel_ctx(struct net *net, u32 mark, u8 type,
>  				*err = security_xfrm_policy_delete(
>  								pol->security);
>  				if (*err) {
> +					xfrm_pol_put(pol);
>  					write_unlock_bh(&net->xfrm.xfrm_policy_lock);
>  					return pol;
>  				}
> @@ -863,6 +864,7 @@ struct xfrm_policy *xfrm_policy_byid(struct net *net, u32 mark, u8 type,
>  				*err = security_xfrm_policy_delete(
>  								pol->security);
>  				if (*err) {
> +					xfrm_pol_put(pol);
>  					write_unlock_bh(&net->xfrm.xfrm_policy_lock);
>  					return pol;
>  				}

We return this policy to the caller, so we better keep
the refcount here. The caller is responsible to drop
the refount.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html