netdev - Re: [patch net-next 15/15] tc: introduce Flower classifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150511153047.GA2222@nanopsycho.mtl.com>
Date:	Mon, 11 May 2015 17:30:48 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Jamal Hadi Salim <jhs@...atatu.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, tgraf@...g.ch,
	jesse@...ira.com, kaber@...sh.net, therbert@...gle.com,
	edumazet@...gle.com, alexander.h.duyck@...hat.com,
	hannes@...essinduktion.org, ast@...mgrid.com, daniel@...earbox.net,
	herbert@...dor.apana.org.au, cwang@...pensource.com,
	john.fastabend@...il.com
Subject: Re: [patch net-next 15/15] tc: introduce Flower classifier

Mon, May 11, 2015 at 02:08:34PM CEST, jhs@...atatu.com wrote:
>On 05/09/15 09:10, Jiri Pirko wrote:
>>This patch introduces a flow-based filter. So far, the very essential
>>packet fields are supported.
>>
>>This patch is only the first step. There is a lot of potential performance
>>improvements possible to implement. Also a lot of features are missing
>>now. They will be addressed in follow-up patches.
>>
>>Signed-off-by: Jiri Pirko <jiri@...nulli.us>
>
>I have a question Jiri: What kind of flower is this? ;->
>Very nice - Glad Dave pushed you to go this direction.
>For a usable classifier that performs reasonably well, i think
>this one is going to look good.
>
>My suggestion is to not add TCA_FLOWER_POLICE attribute.
>Policers can be added via TCA_FLOWER_ACT (which is the modern
>way to do it). Infact i would suggest even in your iproute2
>code, please kill the conditional that tries to parse for
>TCA_FLOWER_POLICE

Hmm, wait. How I should call tcf_exts_init then? Every cls has this POLICE
attr.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html