netdev - Re: [PATCH net] rtnl: don't send rtnl msg for unregistered iface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150511153741.GB2222@nanopsycho.mtl.com>
Date:	Mon, 11 May 2015 17:37:41 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, j.vosburgh@...il.com,
	vfalico@...il.com, gospo@...ulusnetworks.com
Subject: Re: [PATCH net] rtnl: don't send rtnl msg for unregistered iface

Mon, May 11, 2015 at 04:25:46PM CEST, nicolas.dichtel@...nd.com wrote:
>Before the patch, the command 'ip link add bond2 type bond mode 802.3ad'
>causes the kernel to send a rtnl message for the bond2 interface, with an
>ifindex 0.
>
>'ip monitor' shows:
>0: bond2: <BROADCAST,MULTICAST,MASTER> mtu 1500 state DOWN group default
>    link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff
>9: bond2@...E: <BROADCAST,MULTICAST,MASTER> mtu 1500 qdisc noop state DOWN group default
>    link/ether ea:3e:1f:53:92:7b brd ff:ff:ff:ff:ff:ff
>[snip]
>
>Fixes: d4261e565000 ("bonding: create netlink event when bonding option is changed")
>CC: Jiri Pirko <jiri@...nulli.us>
>Reported-by: Julien Meunier <julien.meunier@...nd.com>
>Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
>---
> net/core/rtnetlink.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
>index 837d30b5ffed..721ca1b0e734 100644
>--- a/net/core/rtnetlink.c
>+++ b/net/core/rtnetlink.c
>@@ -3273,6 +3273,8 @@ static int rtnetlink_event(struct notifier_block *this, unsigned long event, voi
> 	case NETDEV_BONDING_INFO:
> 		break;
> 	default:
>+		if (!dev->ifindex)
>+			break;

I don't think this is the correct way to fix this.

How ifindex can be 0 here? Ifindex is set in register_netdevice and
looking at bond_create, I don't see any call to __bond_opt_set before
that. But since it apparently is, the ordering should be changed so
register_netdevice is called first.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html