netdev - Re: [patch net-next 06/15] net: move __skb_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150511160128.GC2222@nanopsycho.mtl.com>
Date:	Mon, 11 May 2015 18:01:28 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Alexander Duyck <alexander.h.duyck@...hat.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, jhs@...atatu.com,
	tgraf@...g.ch, jesse@...ira.com, kaber@...sh.net,
	therbert@...gle.com, edumazet@...gle.com,
	hannes@...essinduktion.org, ast@...mgrid.com, daniel@...earbox.net,
	herbert@...dor.apana.org.au, cwang@...pensource.com,
	john.fastabend@...il.com
Subject: Re: [patch net-next 06/15] net: move __skb_tx_hash to skbuff.c

Mon, May 11, 2015 at 05:55:11PM CEST, alexander.h.duyck@...hat.com wrote:
>On 05/09/2015 06:10 AM, Jiri Pirko wrote:
>>__skb_tx_hash function has no relation to flow_dissect so just muve it
>>to skbuff.c (it is declared in skbuff.h)
>>
>>Signed-off-by: Jiri Pirko <jiri@...nulli.us>
>
>Minor nit, move is spelled with an o, not a u.

Noted.

>
>Also any reason for moving this to skbuff.c instead of dev.c?  It seems like
>this might be better placed there since the only caller is in netdevice.h.

Okay.

>
>- Alex
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html