netdev - Re: [net-next fragmentation icmp v3 1/4] ipv4: introduce frag_expire_skip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 May 2015 08:13:32 -0700
From:	Andy Zhou <azhou@...ira.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [net-next fragmentation icmp v3 1/4] ipv4: introduce frag_expire_skip_icmp()

On Fri, May 8, 2015 at 5:03 AM, Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:
> Hello.
>
> On 5/8/2015 7:26 AM, Andy Zhou wrote:
>
>> Improve readability of skip ICMP for de-fragmentation expiration logic.
>> This change will also make the logic easier to maintain when the
>> following patches in this series are applied.
>
>
>> Signed-off-by: Andy Zhou <azhou@...ira.com>
>> ---
>>   include/net/ip.h       | 10 ++++++++++
>>   net/ipv4/ip_fragment.c | 13 +++++++++----
>>   2 files changed, 19 insertions(+), 4 deletions(-)
>
>
>> diff --git a/include/net/ip.h b/include/net/ip.h
>> index d14af7e..f79193a 100644
>> --- a/include/net/ip.h
>> +++ b/include/net/ip.h
>> @@ -478,6 +478,16 @@ enum ip_defrag_users {
>>         IP_DEFRAG_MACVLAN,
>>   };
>>
>> +/* Return true if the value of 'user' is between 'lower_bond'
>> + * and 'upper_bond' inclusively.
>> + */
>> +static inline bool ip_defrag_user_in_between(u32 user,
>> +                                            enum ip_defrag_users
>> lower_bond,
>> +                                            enum ip_defrag_users
>> upper_bond)
>> +{
>> +       return (user >= lower_bond && user <= upper_bond);
>
>
>    Don't need parens around the *return* expression.
Thanks, I will fix this and the following site in the next version.
>
> [...]
>>
>> diff --git a/net/ipv4/ip_fragment.c b/net/ipv4/ip_fragment.c
>> index cc1da6d..429cefa 100644
>> --- a/net/ipv4/ip_fragment.c
>> +++ b/net/ipv4/ip_fragment.c
>> @@ -173,6 +173,13 @@ static void ipq_kill(struct ipq *ipq)
>>         inet_frag_kill(&ipq->q, &ip4_frags);
>>   }
>>
>> +static bool frag_expire_skip_icmp(u32 user)
>> +{
>> +       return (user == IP_DEFRAG_AF_PACKET ||
>> +               ip_defrag_user_in_between(user, IP_DEFRAG_CONNTRACK_IN,
>> +                                         __IP_DEFRAG_CONNTRACK_IN_END));
>
>
>    Likewise.
>
> [...]
>
> WBR, Sergei
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html