netdev - Re: Suspicious RCU usage in bridge with Linux v4.0-9362-g1fc149933fd4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150512182741.GD9693@x131e>
Date:	Tue, 12 May 2015 20:27:42 +0200
From:	Dominick Grift <dac.override@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: Suspicious RCU usage in bridge with Linux v4.0-9362-g1fc149933fd4

On Mon, May 11, 2015 at 07:53:06AM -0700, Eric Dumazet wrote:
> 
> Hi Dominick
> 
> Have you tried this patch I sent last monday ?
> 
> I will submit formally when I get a test result.
> 
> Thanks

Eric,

I have tested the below patch and everything is in order!

Thank you!

> 
> diff --git a/net/bridge/br_stp_timer.c b/net/bridge/br_stp_timer.c
> index 4fcaa67750fda845ad0a180332c4cd96a9524086..7caf7fae2d5b8aa369b924e1c87a47c343fb8954 100644
> --- a/net/bridge/br_stp_timer.c
> +++ b/net/bridge/br_stp_timer.c
> @@ -97,7 +97,9 @@ static void br_forward_delay_timer_expired(unsigned long arg)
>  		netif_carrier_on(br->dev);
>  	}
>  	br_log_state(p);
> +	rcu_read_lock();
>  	br_ifinfo_notify(RTM_NEWLINK, p);
> +	rcu_read_unlock();
>  	spin_unlock(&br->lock);
>  }
>  
> 
> 

-- 
02DFF788
4D30 903A 1CF3 B756 FB48  1514 3148 83A2 02DF F788
http://keys.gnupg.net/pks/lookup?op=vindex&search=0x314883A202DFF788
Dominick Grift

Content of type "application/pgp-signature" skipped