netdev - Re: [patch net-next 06/15] net: move __skb_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 May 2015 07:22:29 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Cong Wang <cwang@...pensource.com>
Cc:	netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	Thomas Graf <tgraf@...g.ch>, Jesse Gross <jesse@...ira.com>,
	Patrick McHardy <kaber@...sh.net>,
	Tom Herbert <therbert@...gle.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Alexander Duyck <alexander.h.duyck@...hat.com>,
	Hannes Frederic Sowa <hannes@...essinduktion.org>,
	Alexei Starovoitov <ast@...mgrid.com>,
	Daniel Borkmann <daniel@...earbox.net>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	john fastabend <john.fastabend@...il.com>
Subject: Re: [patch net-next 06/15] net: move __skb_tx_hash to skbuff.c

Tue, May 12, 2015 at 01:21:01AM CEST, cwang@...pensource.com wrote:
>On Sat, May 9, 2015 at 6:10 AM, Jiri Pirko <jiri@...nulli.us> wrote:
>> __skb_tx_hash function has no relation to flow_dissect so just muve it
>> to skbuff.c (it is declared in skbuff.h)
>>
>
>It calls __skb_get_hash() in most of the cases, and __skb_get_hash()
>is in flow_dissector.c.
>
>There are many functions declared in skbuff.h but defined in a different
>file than skbuff.c.
>
>Why bother?

To make this a little bit cleaner?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html