netdev - Re: [PATCH -next] net: sched: use counter to break reclassify loops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150512130029.GA22387@breakpoint.cc>
Date:	Tue, 12 May 2015 15:00:29 +0200
From:	Florian Westphal <fw@...len.de>
To:	Jamal Hadi Salim <jhs@...atatu.com>
Cc:	Florian Westphal <fw@...len.de>, netdev@...r.kernel.org
Subject: Re: [PATCH -next] net: sched: use counter to break reclassify loops

Jamal Hadi Salim <jhs@...atatu.com> wrote:
> Florian,
> In general i am in support of removing this - since the use case never
> materialized as being useful. However, this is not the same logic that
> was there before. To get equivalency you need to pass the limit into
> tc_classify_compat() so i can be reset.

AFAICS this re-set only happens when we return something other
than RECLASSIFY which means the caller will not check the limit.

So in fact it should be ok to remove this since the counter will always
start from 0 on next tc_classify() invocation.

> BTW, a faster way to recreate
> tc filter add dev eth0 parent ffff: \
>   protocol ip u32 match u32 0 0 \
> action reclassify

Indeed, thanks for the hint.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html