netdev - Re: [PATCH net v3] rtnl/bond: don't send rtnl msg for unregistered iface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150513144305.GF9559@gospo.home.greyhouse.net>
Date:	Wed, 13 May 2015 10:43:08 -0400
From:	Andy Gospodarek <gospo@...ulusnetworks.com>
To:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:	Jiri Pirko <jiri@...nulli.us>, davem@...emloft.net,
	netdev@...r.kernel.org, j.vosburgh@...il.com, vfalico@...il.com
Subject: Re: [PATCH net v3] rtnl/bond: don't send rtnl msg for unregistered
 iface

On Wed, May 13, 2015 at 02:01:05PM +0200, Nicolas Dichtel wrote:
> Le 12/05/2015 19:12, Andy Gospodarek a écrit :
> >On Tue, May 12, 2015 at 05:58:42PM +0200, Jiri Pirko wrote:
> >>Tue, May 12, 2015 at 05:17:45PM CEST, nicolas.dichtel@...nd.com wrote:
> [snip]
> >>>First, nobody seems to care about NETDEV_CHANGEINFODATA (commit
> >>>d4261e565000 says that it was put only to notify userspace). Hence, we can
> >>>call directly rtmsg_ifinfo().
> >>
> >>Please leave this notifier here. Will be needed in very near future for
> >>LAG offloading purposes.
> >
> >I agree with this.  It is extremely useful for a variety of reasons (not
> >just the offload case), so please to do not remove it.
> No problem, I will keep it.
> 
> For my knowledge, can you explain these "variety of reasons"?

I maybe 'variety' was too strong of a word.  :)

The offload case has uses for it in the future as well as the case where
userspace deamons who are not sending the netlink message but are
monitoring netlink messages as a way to track port status.  Deamons that
would help broker multi-host LAGs are one such example.  

Though it does look like the only event that will happen when
NETDEV_CHANGEINFODATA is called is an RTM_NEWLINK, it will get used more
in the future, so please keep it.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html