netdev - Re: [PATCH net-next] net/bridge: Enable bridge also when switchdev can't be built

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE4R7bCO3Zs=NzZDz9WTKRJznU7BMOkNNZFewNttUXqYsYUq0A@mail.gmail.com>
Date:	Wed, 13 May 2015 08:44:11 -0700
From:	Scott Feldman <sfeldma@...il.com>
To:	Or Gerlitz <ogerlitz@...lanox.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Netdev <netdev@...r.kernel.org>, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH net-next] net/bridge: Enable bridge also when switchdev
 can't be built

On Wed, May 13, 2015 at 3:08 AM, Or Gerlitz <ogerlitz@...lanox.com> wrote:
> Currently switchdev doesn't build on older gcc version such as 4.4.6
>
> The reason for the compile error is such that it causes a failure
> to build the bridge too, even when switchdev isn't configured (the
> stub isn't enough), fix it.
>
> CC [M]  net/bridge/br_stp.o
> net/bridge/br_stp.c: In function 'br_set_state':
> net/bridge/br_stp.c:44: error: unknown field 'stp_state' specified in initializer
>
> Signed-off-by: Or Gerlitz <ogerlitz@...lanox.com>
> ---
>  net/bridge/br_stp.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/net/bridge/br_stp.c b/net/bridge/br_stp.c
> index b9300da..752783a 100644
> --- a/net/bridge/br_stp.c
> +++ b/net/bridge/br_stp.c
> @@ -39,17 +39,19 @@ void br_log_state(const struct net_bridge_port *p)
>
>  void br_set_state(struct net_bridge_port *p, unsigned int state)
>  {
> +#ifdef CONFIG_NET_SWITCHDEV
>         struct switchdev_attr attr = {
>                 .id = SWITCHDEV_ATTR_PORT_STP_STATE,
>                 .stp_state = state,
>         };
>         int err;
>
> -       p->state = state;
>         err = switchdev_port_attr_set(p->dev, &attr);
>         if (err && err != -EOPNOTSUPP)
>                 br_warn(p->br, "error setting offload STP state on port %u(%s)\n",
>                                 (unsigned int) p->port_no, p->dev->name);
> +#endif
> +       p->state = state;
>  }

Isn't this the same issue with anonymous unions and older gcc?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html