netdev - Re: [PATCH net-next v2] net: core: set and refine qdisc pkt len before tc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5553C3F1.4070208@iogearbox.net>
Date:	Wed, 13 May 2015 23:36:49 +0200
From:	Daniel Borkmann <daniel@...earbox.net>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	davem@...emloft.net, fw@...len.de, ast@...mgrid.com,
	jhs@...atatu.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: core: set and refine qdisc pkt len before
 tc_classify

On 05/13/2015 11:20 PM, Eric Dumazet wrote:
...
> Is qdisc_pkt_len_init() still inlined, now it has 2 callers ?
>
> People using policers on ingress are very often disabling GRO for
> various historical reasons.

Yes, tested policer and for getting it working on my side, GRO needs
to be off.

> Since handle_ing() is very uncommon, I would prefer not slowing down tx
> just so that GRO ~5% error in ingress is fixed.

I see a callq dc0 <qdisc_pkt_len_init> now. Ok, in that case Florian's
original version is fine:

   http://patchwork.ozlabs.org/patch/471346/

> I noticed you did not CC me, don't be afraid to include me next time one
> of my commit is referred in a changelog ;)

Hmm, I did Cc you. ;)

To:	davem@...emloft.net
Cc:	fw@...len.de, ast@...mgrid.com, jhs@...atatu.com,
	eric.dumazet@...il.com, netdev@...r.kernel.org,
	daniel@...earbox.net

Thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html