netdev - Re: [PATCH v5] net: phy: micrel: Fix regression in kszphy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150512.231909.896139778564783277.davem@davemloft.net>
Date:	Tue, 12 May 2015 23:19:09 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	niklas.cassel@...s.com
Cc:	f.fainelli@...il.com, festevam@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, johan@...nel.org, niklass@...s.com,
	stable@...r.kernel.org
Subject: Re: [PATCH v5] net: phy: micrel: Fix regression in kszphy_probe

From: Niklas Cassel <niklas.cassel@...s.com>
Date: Tue, 12 May 2015 09:43:14 +0200

> Don't do clock-mode-select if clk == NULL,
> since when building without CONFIG_HAVE_CLK,
> clk_get returns NULL and clk_get_rate returns 0.
> 
> Doing clock-mode-select in this cause causes kszphy_probe to
> return -EINVAL and thus prevents the device from being probed.
> 
> The original code (before regression) would return 0
> when building without CONFIG_HAVE_CLK.
> 
> Cc: stable <stable@...r.kernel.org> # 3.18+
> Fixes: 1fadee0c3645 ("net/phy: micrel: Add clock support for
> KSZ8021/KSZ8031")
> Reviewed-by: Fabio Estevam <fabio.estevam@...escale.com>
> Reviewed-by: Johan Hovold <johan@...nel.org>
> Signed-off-by: Niklas Cassel <niklass@...s.com>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html